fix(jupiter): support sqlite migration#1030
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for SQLite migration while refactoring the database connection and tree retrieval logic across several modules.
- Added the Hash trait derivation for tree item types to facilitate hash-based collections.
- Modified storage methods to accept tree hash vectors by reference and updated database migration logic, including conditional enum creation.
- Updated Git API service and pack handlers to utilize a caching mechanism for tree retrieval.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| mercury/src/internal/object/tree.rs | Added Hash derivation for TreeItemMode and TreeItem. |
| jupiter/src/storage/mono_storage.rs | Changed get_trees_by_hashes parameter to a reference type. |
| jupiter/src/storage/init.rs | Refactored connection creation and migration triggering for both PostgreSQL and SQLite. |
| jupiter/src/storage/git_db_storage.rs | Updated parameter passing to match mono_storage. |
| jupiter/migration/src/m20250314_025943_init.rs | Adjusted migration to conditionally create enum types only for PostgreSQL. |
| ceres/src/pack/monorepo.rs | Updated tree retrieval calls to use reference parameters and caching. |
| ceres/src/pack/import_repo.rs | Updated tree retrieval and commit traversal to use caching and reference parameters. |
| ceres/src/model/git.rs | Modified conversion of tree items to include commit information. |
| ceres/src/api_service/mono_api_service.rs | Updated API service functions to incorporate caching and reference parameters. |
| ceres/src/api_service/mod.rs | Introduced GitObjectCache and updated trait signatures for caching support. |
| ceres/src/api_service/import_api_service.rs | Updated API service methods to pass references and utilize caching for tree lookups. |
Comments suppressed due to low confidence (1)
jupiter/migration/src/m20250314_025943_init.rs:48
- The enum creation for MergeStatusEnum is duplicated for DatabaseBackend::Postgres; consider consolidating these calls to prevent potential conflicts or redundant operations.
manager.create_type(Type::create().as_enum(MergeStatusEnum).values(MergeStatus::iter()).to_owned(),).await?;
| } | ||
|
|
||
| let want_tree_ids = want_commits.iter().map(|c| c.tree_id.to_string()).collect(); | ||
| let want_tree_ids = &want_commits.iter().map(|c| c.tree_id.to_string()).collect(); |
There was a problem hiding this comment.
Binding a reference to the result of collect() may lead to lifetime issues; consider explicitly creating a vector variable to hold the collected values before referencing it.
Suggested change
| let want_tree_ids = &want_commits.iter().map(|c| c.tree_id.to_string()).collect(); | |
| let want_tree_ids_vec: Vec<String> = want_commits.iter().map(|c| c.tree_id.to_string()).collect(); | |
| let want_tree_ids = &want_tree_ids_vec; |
genedna
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.